Remove scrolling in FOAM Example

[bartonhammond]

Allow display of entire code/example w/o scrolling Increase display size

Changed to:

From:

[bartonhammond]

Person Model was displayed twice

[bartonhammond]

The following code has no effect on display. Either display is wrong or this code is irrelevant.

      // Format table cells that contain children: List first names.
      tableFormatter: function(children) {
        if ( ! children ) return '';
        return children.map(function(c) { return c.firstName; }).join(', ');
      }

[kgrgreer]

@bartonhammond

Person Model was displayed twice

What do you mean? There are two people: Jaden and Willow, which is why there are two Persons shown. Is that what you mean?

[bartonhammond]

The definition/declaration was twice - I removed the unnecessary duplicate:

        <code-snippet ref="Person" title="Person Model" />

[kgrgreer]

@bartonhammond

The following code has no effect on display. Either display is wrong or this code is irrelevant.

The data in the third-column appears as: Jaden, Willow

Which is the result of this tableFormatter.

It affects the output in example 1.3.11, but it doesn't have any change in 1.3.10, which isn't a table. Is that what you mean?

[kgrgreer]

I see. Thx

On 31 March 2016 at 16:49, Barton Hammond notifications@github.com wrote:

The definition/declaration was twice - I removed the unnecessary duplicate:

    <code-snippet ref="Person" title="Person Model" />

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/foam-framework/foam/pull/551#issuecomment-204121753

[bartonhammond]

... it doesn't have any change in 1.3.10, which isn't a table. Is that what you mean?

Yes

[kgrgreer]

It's the same Model referenced from both examples (and another one as well), which is why the tableFormatter appears. I've added a comment to explain this.

[kgrgreer]

All suggestions have been addressed, one way or another. Thank you very much.