search

foambubble / foam

A personal knowledge management and sharing system for VSCode
https://foambubble.github.io/
Other
15.23k stars 650 forks source link

Wikilinks Not Displayed Correctly In Tables With VS Code 1.82.0 #1284

Closed micharris42 closed 11 months ago

micharris42 commented 1 year ago

Describe the bug

After upgrading to version 1.82.0, wikilinks are no longer displayed correctly in tables. They are still recognized as links by Foam (they are listed in the Connections panel, and hovering over a link activates the quick preview), but visually they no longer change appearance with the extension active. Please see the screenshot below.

Small Reproducible Example

No response

Steps to Reproduce the Bug or Issue

  1. Create a wikilink: [[example]]
  2. The wikilink is displayed properly
  3. Create a table
  4. Add a wikilink to a field: [[example]]
  5. The wikilink is not displayed properly

Expected behavior

That wikilinks be visually consistent throughout a set of notes, regardless of whether the link is included as part of a table.

Screenshots or Videos

Screenshot 2023-09-07 205819

Operating System Version

Windows 11

Visual Studio Code Version

VSCodium 1.82.0

Additional context

No response

micharris42 commented 11 months ago

Closing this issue. After a bit of research, realized the cause of the links changing color was that the textmate scopes for links specifically in tables seems to have changed. Was able to restore the original coloring by updating my settings.