foambubble / foam

A personal knowledge management and sharing system for VSCode
https://foambubble.github.io/
Other
15.28k stars 650 forks source link

Foam Web Extension #1395

Closed riccardoferretti closed 1 week ago

riccardoferretti commented 1 week ago

This PR is heavily inspired and influenced by #1290 - thanks @pderaaij for spearheading and working through this complex feature. See that PR for more context.

Compared to #1290 , this PR:

This way:

The only thing I would have liked to add was running a basic test in the web extension (without the need for mocha) that would only test if the extension is present. Then again, this can be added as a second step.

pderaaij commented 1 week ago

Looks good to me!

riccardoferretti commented 1 week ago

Great @pderaaij ! Again, I want to empathise that you basically did all the hard work here, I just repackaged it to avoid those extra dependencies 🙏