focalintent / FastLED-Sparkcore

SparkCore specific port of FastLED
MIT License
24 stars 34 forks source link

Update to FastLED 3.1.1? #12

Open gelicia opened 8 years ago

gelicia commented 8 years ago

I've been looking to use FastLED for many reasons, one of which is the power management functionality that was added in FastLED 3.1.1. If you get a moment, could you update this library to use 3.1.1?

focalintent commented 8 years ago

Unfortunately, because of problems in how the particle folks do libraries, pulling over 3.1 will take more than a moment (and since i'm in the middle of some major library overhaul, if i'm going to have to do this ugly juggling, I'd like to only do it once).

However, luckily for you - power management is in what's in the spark core - you just have to call a slightly different set of functions to use it - take a look at https://github.com/focalintent/FastLED-Sparkcore/blob/master/firmware/power_mgt.h

gelicia commented 8 years ago

Thank you for being the single most helpful person in dealing with this (see https://community.particle.io/t/fastled-update/23120/). I appreciate it immensely.

focalintent commented 8 years ago

By the way - this https://community.particle.io/t/library-import-flattens-directory-structure-workaround/9915/25 - is the reason why there's a separately versioned repo for particle than FastLED proper (and yes, the version numbers are out of sync because particle requires me to rev the version number with every release push).

gelicia commented 8 years ago

I figured the version numbers and your fork were done for a reason- I was no way blaming you for the confusion. As a dev I would also love to pull downstream but realized that isn't possible with the other talk that's been around on the library.

I think that when they do required versioning like they do there's bound to be some confusion. One would assume those being helpful in the thread would also be understanding of confusing aspects and maybe someone who's stumbling into a minefield without knowing how to fully elaborate the problem.

Anyway, thanks again for your time and pointing out the functions I'm looking for.