search

focalintent / FastLED-Sparkcore

SparkCore specific port of FastLED
MIT License
24 stars 34 forks source link

conflicting declaration 'typedef volatile uint8_t RwReg' #15

Open konahart opened 7 years ago

konahart commented 7 years ago

Including FastLED from Particle Build now produces an error that it previously did not: 


FastLED/led_sysdefs_arm_stm32.h:36:32: error: conflicting declaration 'typedef volatile uint8_t RwReg'
 typedef volatile       uint8_t RwReg
Sturgeon637 commented 7 years ago

I have the same issue.

cosmicc commented 7 years ago

looks like anther variable conflict. Same thing here.

GreatHornedOwl commented 7 years ago

Can we get some resolution here?

Sturgeon637 commented 7 years ago

Hello GreatHornedOwl, For right now, just set your System Firmware Target to no greater than 0.6.0 and #include "Particle.h". You can set this in the devices panel. Click on the ">" and you will see the System Firmware Target pull down.

Cheers,

Sturgeon637

GreatHornedOwl commented 7 years ago

Hi Sturgeon637,

That worked, thanks a million!

GreatHornedOwl

RickDB commented 7 years ago

Workaround does the trick 👍 , any idea if this can be fixed in any future Particle library update?

focalintent commented 7 years ago

When I get back to working on library stuff it will get fixed.

RickDB commented 7 years ago

Found a quick fix for this by renaming those conflicting variables, mind if I do a PR for review? Tried different names for variable like adding additional LED suffix but compiler complained so just made RwReg -> Rwrg and RoReg -> RoRg so that is doesn't collide with Particle internals.

Based it off this fork as that makes it compatible with Particle V2 library as well which should make it as little work as possible to publish afterwards :)

https://github.com/ACamposPT/FastLED-Sparkcore

Tested in build particle environment with firmware 0.6.2 (using internal repo publish) and both the AtmoOrbs work fine after flashing.

RickDB commented 7 years ago

Just committed if you want to take a peek:

https://github.com/RickDB/FastLED-Sparkcore/tree/fix_variable_conflicts

Jerware commented 7 years ago

This was fixed in Particle Firmware 0.6.2 and was covered in the following thread. This issue can be closed.

https://community.particle.io/t/fastled-not-compiling-to-photon/30031/25