Update open event details buttons to use i18n - Githubissues

focallocal / fl-maps

The Public Happiness Movement: A platform bringing people and communities together to solve any and all societal issues. BTM branch is a project aiming to solve world involuntary homelessness. PHM brings communities together to create social initiatives for kindness and well-being.

https://publichappinessmovement.com

MIT License

143 stars 95 forks source link

Update open event details buttons to use i18n #1136

Closed petesfrench closed 1 year ago

petesfrench commented 1 year ago

Done

Updates event details buttons found in the map from 'More' to 'Open'
Updates to use i18n
Includes 'Meteor' in a file where it was throwing an error

petesfrench commented 1 year ago

Any ideas why Travis is failing here? I haven't touched anything that should affect it

AndyatFocallocal commented 1 year ago

@petesfrench Travis needs to be setup again from the beginning tbh. We should have three live sites, for deploy-phm, deploy-btm, and master. One testing server and one for each main project.

After an error and some down time @TLMcNulty fixed them, but since then BTM doesn't build and PHM appears to build whichever branch was most recently updated. My suspicion is that the old system wasn't fully removed and BTM i'm not sure about.

Anyway, i wouldn't worry about it. It will still merge to the live publichappinessmovement site.

As the branches are currently mixed up can you please make your PR to both branches deploy-phm and master?

AndyatFocallocal commented 1 year ago

Great job, that all looks exactly to our format.

I've requested @Marvelxy reviews it as i wasn't aware the import { Meteor } from 'meteor/meteor' change was needed and would like him to confirm.

Marvelxy commented 1 year ago

The Meteor import is needed. I wonder how we missed it LOL 🤦‍♂️🤷‍♂️😂

AndyatFocallocal commented 1 year ago

I wonder how it worked without it. Great spot @petesfrench. Can you also send this PR to deploy-phm and deploy-btm branches please.

AndyatFocallocal commented 1 year ago

I don't think Master is going to build. That's ok as the live site is running off of deploy-phm, so once the PR is made to that branch we should se the change go live.

(obv we need to look into it and get the backend tidied up soon)

petesfrench commented 1 year ago

Great, thank you for the review. Sorry I wasn't able to look at this until now, I was not well last week.

AndyatFocallocal commented 1 year ago

Glad you're better now