focus-editor / focus

A simple and fast text editor
GNU General Public License v3.0
1.73k stars 94 forks source link

All fonts show up as mono #195

Open Leblayd opened 11 months ago

Leblayd commented 11 months ago

Describe the bug Changing the font produces some weird results. Any non-mono font I choose shows up terribly stretched out as if they were mono.

I've found that the default one is FiraCode-Retina, which does not have Japanese characters, so I thought looking for an alternative would solve that. (Though even when I do switch, they don't work, so that can be considered a separate issue I guess. )

To Reproduce Steps to reproduce the behavior:

  1. Open global config
  2. Change the font to something like Calibri
  3. Save
  4. Consider resorting to the ancient remedy of applying a spoon to your eyes to rescue them from the hellish sight before you

Expected behavior Mono fonts should be mono. Regular should be regular.

Screenshots Mono fonts are okay:

Regular fonts are not:

focus-editor commented 11 months ago

This is of course known. We choose not to fix this right now because this editor's primary use case is code editing. We may or may not fix this in the future. Laying out text properly is not free and we're not sure we want to make everyone pay for it with performance when most people will never use non-monospaced fonts.

On Thu, 28 Sept 2023 at 11:19, Leblay Dávid @.***> wrote:

Describe the bug Changing the font produces some weird results. Any non-mono font I choose shows up terribly stretched out as if they were mono.

I've found that the default one is FiraCode-Retina, which does not have Japanese characters, so I thought looking for an alternative would solve that. (Though even when I do switch, they don't work, so that can be considered a separate issue I guess. )

To Reproduce Steps to reproduce the behavior:

  1. Open global config
  2. Change the font to something like Calibri
  3. Save
  4. Consider resorting to the ancient remedy of applying a spoon to your eyes to rescue them from the hellish sight before you

Expected behavior Mono fonts should be mono. Regular should be regular.

Screenshots Mono fonts are okay:

Regular fonts are not:

-

[image: image] https://user-images.githubusercontent.com/33326417/271126475-0427b296-d29a-4e40-bdfb-9f6bec290e38.png vs [image: image] https://user-images.githubusercontent.com/33326417/271126519-2bc44714-748f-41a2-8282-0a50e56b56f5.png

[image: image] https://user-images.githubusercontent.com/33326417/271127009-c6db9ff4-e370-415f-8f6f-109267a783e5.png vs [image: image] https://user-images.githubusercontent.com/33326417/271127042-1fa7a5cd-8ac2-48d3-b2fa-71fdcec7b9fa.png

[image: image] https://user-images.githubusercontent.com/33326417/271127449-81e30b17-d2bc-4081-b19d-4e865a2374c4.png vs [image: image] https://user-images.githubusercontent.com/33326417/271127513-6329f70b-ae54-440a-a98e-a99c22d16a37.png

OS: Windows 11

Focus Version: 0.2.0

— Reply to this email directly, view it on GitHub https://github.com/focus-editor/focus/issues/195, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4OX77SHAYNYS5KV4DN36FTX4SQ77ANCNFSM6AAAAAA5KBFJFA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

flysand7 commented 11 months ago

There's also a way to make this incorrect by fixing. Sublime has this issue when typing japanese characters they aren't the same width as normal half-width latin characters.