search

focus-editor / focus

A simple and fast text editor
GNU General Public License v3.0
1.82k stars 99 forks source link

V3 -> V4 config migration doesn't preserve theme colors #373

Closed fbjerno closed 6 months ago

fbjerno commented 6 months ago

Describe the bug Config version 4 added new options for highlighting code. As far as I can tell these use the default colors rather than grabbing the color that would previously have been used for that type of code from the old config during migration (phew!).

To Reproduce Steps to reproduce the behavior:

  1. Open Focus v0.3.5 the Handmade Hero theme. The theme is displayed correctly.
  2. Open the nighly Focus build (0.3.6-dev). The theme is auto-migrated to version 4. Some types of code now use an incorrect color. For these code elements, the color is the same for all migrated themes.

Expected behavior The old colors of the theme are preserved.

Screenshots image (left: v3, right: v4, migrated from v3)

focus-editor commented 6 months ago

Thanks for catching this before release! People's configs would be corrupted if we released this. The fix should be in the next nightly.