focus-shift / jollyday

Jollyday - A worldwide public holidays library
Apache License 2.0
79 stars 23 forks source link

Warning module not found #445

Open XSpielinbox opened 8 months ago

XSpielinbox commented 8 months ago

More information

When compiling jollyday I get the following warnings:

[...]
[INFO] --- compiler:3.12.1:compile (default-compile) @ jollyday-core ---
[INFO] Recompiling the module because of changed source code.
[INFO] Compiling 75 source files with javac [debug target 11 module-path] to target/classes
[WARNING] system modules path not set in conjunction with -source 11
[WARNING] /home/[...]/Documents/[...]/jollyday/jollyday-core/src/main/java/module-info.java:[17,28] module not found: de.focus_shift.jollyday.jaxb
[WARNING] /home/[...]/Documents/[...]/jollyday/jollyday-core/src/main/java/module-info.java:[18,28] module not found: de.focus_shift.jollyday.jackson
[WARNING] /home/[...]/Documents/[...]/jollyday/jollyday-core/src/main/java/module-info.java:[19,36] module not found: de.focus_shift.jollyday.jackson.test
[WARNING] /home/[...]/Documents/[...]/jollyday/jollyday-core/src/main/java/module-info.java:[20,33] module not found: de.focus_shift.jollyday.jaxb.test
[WARNING] /home/[...]/Documents/[...]/jollyday/jollyday-core/src/main/java/module-info.java:[22,36] module not found: de.focus_shift.jollyday.jackson.test
[WARNING] /home/[...]/Documents/[...]/jollyday/jollyday-core/src/main/java/module-info.java:[23,33] module not found: de.focus_shift.jollyday.jaxb.test
[WARNING] /home/[...]/Documents/[...]/jollyday/jollyday-core/src/main/java/module-info.java:[7,39] package is empty or does not exist: focus_shift.de.jollyday.schema.holiday
[INFO] 
[...]
[INFO] --- compiler:3.12.1:compile (default-compile) @ jollyday-jackson ---
[INFO] Recompiling the module because of changed dependency.
[INFO] Compiling 45 source files with javac [debug target 11 module-path] to target/classes
[WARNING] system modules path not set in conjunction with -source 11
[WARNING] /home/[...]/Documents/[...]/jollyday/jollyday-jackson/src/main/java/module-info.java:[23,36] module not found: de.focus_shift.jollyday.jackson.test
[WARNING] /home/[...]/Documents/[...]/jollyday/jollyday-jackson/src/main/java/module-info.java:[26,36] module not found: de.focus_shift.jollyday.jackson.test
[INFO] 
[...]
[INFO] --- compiler:3.12.1:compile (default-compile) @ jollyday-jaxb ---
[INFO] Recompiling the module because of changed dependency.
[INFO] Compiling 47 source files with javac [debug target 11 module-path] to target/classes
[WARNING] system modules path not set in conjunction with -source 11
[WARNING] /home/[...]/Documents/[...]/jollyday/jollyday-jaxb/src/main/java/module-info.java:[20,33] module not found: de.focus_shift.jollyday.jaxb.test
[WARNING] /home/[...]/Documents/[...]/jollyday/jollyday-jaxb/src/main/java/module-info.java:[22,33] module not found: de.focus_shift.jollyday.jaxb.test
[INFO] 
[...]

Note: I only have JDK 17 installed, which might be the cause for [WARNING] system modules path not set in conjunction with -source 11.

derTobsch commented 8 months ago

Note: I only have JDK 17 installed, which might be the cause for [WARNING] system modules path not set in conjunction with -source 11.

is fixed in #450

derTobsch commented 8 months ago

The module warnings are, because the modules has not been build to this time and therefore the warning or I am wrong?

XSpielinbox commented 8 months ago

Note: I only have JDK 17 installed, which might be the cause for [WARNING] system modules path not set in conjunction with -source 11.

is fixed in #450

Thank you. Yes, that fixes that warning.

XSpielinbox commented 8 months ago

The module warnings are, because the modules has not been build to this time and therefore the warning or I am wrong?

Hm, yes, could be. How would one be doing this then normally? Is there a way to build it in a way that all dependencies are built beforehand? It does not seem correct to me to always get this warning, but I don't know after all whether this is to be expected.

derTobsch commented 3 months ago

see https://stackoverflow.com/questions/53670052/how-to-define-qualified-exports-to-unknown-modules and https://stackoverflow.com/questions/53712924/unable-to-resolve-module-using-module-source-path/53717183#53717183