search

focusaurus / atom-format-shell

Format shell script from within atom text editor
MIT License
6 stars 1 forks source link

Allow custom command line argument #4

Closed 0rax closed 6 years ago

0rax commented 6 years ago

Hi, I just discovered your plugin after looking at the shfmt project though I would like to be able to parse custom cli argument to the binary such as -bn or -ci which can not be set using your current configuration.

Letting users add command line arguments by themselves would allow them to use newer shfmt feature without the need for you to add a custom tick box each time one is added.

Thanks

focusaurus commented 6 years ago

Thanks for the feature request. I'll have a look at it. I'll see how difficult explicit options would be and weigh that against letting users just configure the command line.

focusaurus commented 6 years ago

Fixed via e27bbf55786434c7dbd55857a5e835c7639adbd9. Try v2.1.0 and let me know how it works. I added GUI settings for these.

0rax commented 6 years ago

Works perfectly, Thanks !

I just had an issue installing it (Atom did not see an update for the package and format-shell is still listed as version 2.0.0 on APM) but installing it via the repository worked fine (via apm install focusaurus/atom-format-shell).