search

fofix / fofix

Frets on Fire X: a fork of Frets on Fire with many added features and capabilities
https://fofix.org
Other
414 stars 90 forks source link

Background video sync #71

Open arielenter opened 7 years ago

arielenter commented 7 years ago

Hello,

Is there a reason why videos seem to be played slower than they original are? I have some videos that I have sync with their songs whit a video editor and play well on programs like performous, but in fofix they fall behind.

I found people like in this video that suggest to speed up the video so that it gets some what sync with the song:

https://youtu.be/JCjo3IL_oIs

That person says it depends from pc to pc, which made me believe it has something to do with the computers specs which to me doesn't make a lot of sense unless fofix is leavening the video playback as the last thing to render in importance. Following that idea I thought that maybe reducing the video's fps could help fofix to play it easily but that didn't work.

Would this be fix in the future? It doesn't seem right now that video sync was a feature that fofix was trying to archive since pausing the song doesn't pause the video either. I don't mind so much but I would like to know and maybe be able to suggest the feature.

Mean while would it be worth trying to find the "magic number" to speed all my video and get them to sync or would it be futile? I mean, if depends on the computer workload or different conditions I would it attempt it.

Thank you so much for the work given to the project, I've being following the progress, and I think is awesome how things are coming up. Is there still no way to make donations? Thanks again for the great job.

arielenter commented 7 years ago

So I made some tests, and even when it's possible to speed the video to get it some what sync with the music, the video doesn't always plays the same and unsync when there is a slow down in the game for any reason. This doesn't happen with the notes and song of course, and I wonder if it could be possible to do the same thing for the video.

In any case, I'm happy to be able to at least play videos in the background, although as I said, performous does seem to handle background videos better keeping them sync, but fofix has always been my favorite, and I do consider them to have a different focus and feeling, both are great though.

Also I want to rectify my self, the video does get paused when pausing the song, but the video keeps playing on the count down when resume. Maybe video sync is planned for the future and I been speculating all day xD

Any way thank you for your attention.

mxmau commented 7 years ago

Hello, I'm thinking about this for a long time, Maybe We can try something like this:

<> import Video.controller.speed

a = Get(Video.fps) x= Get(CurrentFps)

if x ==a: z= Video.controller.speed.default(); else z =Video.controller.speed.set(a/x)

arielenter commented 7 years ago

Looks good, but would it also prevent the video from unsyncing when there is for instance a slow down in the game? As I said I notice that the video doesn't always plays the same on every game, unlike what happens with the notes and the song.