fofr / cog-comfyui

Run ComfyUI with an API
https://replicate.com/fofr/any-comfyui-workflow
MIT License
464 stars 106 forks source link

AnimateDiff now broken. #146

Closed drommerkiller closed 1 week ago

drommerkiller commented 1 month ago

It seems that something is updated and now animatediff workflows do not work anymore. I have local version and online version that has not been modified for a while and it suddenly stopped working.

Every workflow, even when used on Replicate form gives this error: Executing node 41, title: Load AnimateDiff LoRA πŸŽ­πŸ…πŸ…“, class type: ADE_AnimateDiffLoRALoader !!! Exception during processing!!! AnimateDiffLoraLoader.load_motion_lora() missing 1 required positional argument: 'name' Traceback (most recent call last): File "/src/ComfyUI/execution.py", line 152, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "/src/ComfyUI/execution.py", line 82, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) File "/src/ComfyUI/execution.py", line 75, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) TypeError: AnimateDiffLoraLoader.load_motion_lora() missing 1 required positional argument: 'name' Prompt executed in 1.54 seconds outputs: {}

Seems to relate to motion lora loader.

I have trained one own model and that still works, so this new bug has come after i trained that. Workaround for me is to use my own model for every workflow. Downside is that my own model has constant cold boots and can be really slow to use.

fofr commented 3 weeks ago

Can you share an example prediction or workflow? My guess is that the animate diff motion lora custom node has changed

fofr commented 3 weeks ago

Looks like you need to just pass in the name of the motion lora too? https://github.com/Kosinkadink/ComfyUI-AnimateDiff-Evolved/blob/c5c27807f0ba15507b8c9a7a650a04837351753a/animatediff/nodes_lora.py#L17

fofr commented 3 weeks ago

It used to be lora_name, now it's just name

Screenshot 2024-08-21 at 11 06 23
drommerkiller commented 3 weeks ago

It was the name change problem. Now there is another problem for me:

HighRes-Fix Script used to work by leaving those empty as i'm only doing latent upscaling and those would just load extra files. Now it does not run trough if some value is empty. Is there workaround for that?

Thanks for checking this out! Next time i'll try to remember to check the commit changes before posting here.

drommerkiller commented 2 weeks ago

It used to be lora_name, now it's just name

Screenshot 2024-08-21 at 11 06 23

Changing lora_name to name gives this error: - Value not in list: name: '16000_cseti_4507345_general-70vid_mv2.safetensors' not in [] So it still checks is the name on some list before using it. Are Motion loras copied to wrong directory?: 16000_cseti_4507345_general-70vid_mv2.safetensors exists in ComfyUI/models/animatediff_loras

That file should go to: ComfyUI\models\animatediff_motion_lora

fofr commented 2 weeks ago

I think this commit will fix it (I haven't pushed latest to Replicate yet) https://github.com/fofr/cog-comfyui/commit/ca4ae0ec76a54874320797e4155d355872465c58

fofr commented 1 week ago

Fixed motion lora directory