Add `ComfyUI-Impact-Pack`

fofr / cog-comfyui

Run ComfyUI with an API

https://replicate.com/fofr/any-comfyui-workflow

MIT License

544 stars 124 forks source link

Add `ComfyUI-Impact-Pack` #20

Closed digitaljohn closed 9 months ago

digitaljohn commented 9 months ago

Closes #13

fofr commented 9 months ago

Nice! Do you know if any of the custom nodes download any models on the fly?

digitaljohn commented 9 months ago

Likely yes, want me to identify?

fofr commented 9 months ago

That would be amazing, yes.

digitaljohn commented 9 months ago

Looks like its just these models:

https://github.com/ltdrdata/ComfyUI-Impact-Pack/blob/43bca637c236aef6d9749f04d9917cac9ff3ff34/install.py#L266-L272

fofr commented 9 months ago

Hmm, it looks like a few things happen when you first start the impact pack:

it runs install which updates pip packages
it installs ultralytics, which downloads 3 further models

I'm adding some code to automatically copy the config when importing the custom node, rather than generating it, and will take from there.

Do you have some example impact pack workflows I can test with?

fofr commented 9 months ago

This also poses a problem: https://github.com/ltdrdata/ComfyUI-Impact-Pack/blob/43bca637c236aef6d9749f04d9917cac9ff3ff34/__init__.py#L36

The .dockerignore purposefully ignores all .git directories as they're weight we don't need in the container. This will always attempt to delete the subpack path.

fofr commented 9 months ago

I've decided to fork the main repo and comment out the troublesome parts: https://github.com/ltdrdata/ComfyUI-Impact-Pack/compare/Main...fofr:ComfyUI-Impact-Pack:Main

fofr commented 9 months ago

New PR: https://github.com/fofr/cog-comfyui/pull/22