search

fog / fog-aliyun

Fog provider for aliyun
MIT License
37 stars 24 forks source link

Update Compute to use provider::service syntax #155

Open sethboyles opened 2 years ago

sethboyles commented 2 years ago

When upgrading to fog-core 2.1, we see a lot of errors like this: 


                NameError:
                  uninitialized constant Fog::Aliyun::Compute
                  Did you mean?  Fog::Compute

Updating the syntax should resolve this and make fog-aliyun compatible with fog-core 2.1

jochenehret commented 1 month ago

This PR is not required anymore. We've tested https://github.com/cloudfoundry/cloud_controller_ng/pull/3744 on an AliCloud landscape and found no issues.

We also did a counter test and inserted this hack again:

# Hack until https://github.com/fog/fog-aliyun/pull/155 is merged and released
Fog::Aliyun::Compute = Fog::Compute::Aliyun

and then we received this error:

rake aborted!
NameError: uninitialized constant Fog::Compute::Aliyun (NameError)

Fog::Aliyun::Compute = Fog::Compute::Aliyun
                                   ^^^^^^^^
/var/vcap/data/packages/cloud_controller_ng/f3dbe2f9a2f67f55efc2e49100c58b67efdb8065/cloud_controller_ng/lib/cloud_controller/blobstore/fog/providers.rb:11:in `<top (required)>'

So the workaround is really not required anymore.