search

fog / fog-aws

Module for the 'fog' gem to support Amazon Web Services http://aws.amazon.com/
MIT License
296 stars 353 forks source link

Fix frozen string literal issues part 2 #711

Open chaadow opened 2 weeks ago

chaadow commented 2 weeks ago

Followup: https://github.com/fog/fog-aws/pull/709

After running tests locally I managed to fix all of the frozen string literals issues.

This PR however depends on fog-core and fog-xml being fixed ( I will create separate PRs on those repos) EDIT: here are the 2 PRs:

It's worth mentioning that on fog-core and fog-xml, I will just fix just enough to make the tests green here I haven't yet run the tests on those repos.

@geemus What do you think? Do you mind providing me with a simple github action .yml file in which i can enable RUBYOPT

here is the command I run locally: bundle exec rake RUBYOPT="--enable-frozen-string-literal"

chaadow commented 2 weeks ago

Ok sorry, I managed to find the shared config ( i was a bit lost with .github/.github thought it was some Github magic)

As we've said in the previous PR, the idea is to manually enable it gem by gem, and once we feel comfortable we make it common to every gem in the shared CI config.

(Right now, tests are failing because the dependent PRs are not yet merged/released)

chaadow commented 2 weeks ago

I think a good idea would be to add timeouts on the CI, it's taking a bit long i'm sorry. I will do tomorrow