fog / fog-azure

MIT License
19 stars 18 forks source link

Update azure dependency to ~> 0.7 #29

Closed vishrutshah closed 8 years ago

vishrutshah commented 8 years ago
jeffmendoza commented 8 years ago

@vishrutshah I am unable to test this PR, can you describe any validation you have done?

vishrutshah commented 8 years ago

Hi @jeffmendoza Thanks for the quick response. I've validated existing tests except database ones as following commands:

vishrut@visshamac fog-azure (update-azure-depedency) $ bundle exec shindont tests/models/compute/image_tests.rb 
[fog][WARNING] Setting default fog timeout to 2000 seconds

  Fog::Compute[:azure] | image model (azure, compute) +++++  
  5 succeeded in 0.176236 seconds

vishrut@visshamac fog-azure (update-azure-depedency) $ bundle exec shindont tests/models/compute/server_tests.rb 
[fog][WARNING] Setting default fog timeout to 2000 seconds

  Fog::Compute[:azure] | server model (azure, compute) #  
  1 pending, 0 succeeded in 0.17882 seconds

vishrut@visshamac fog-azure (update-azure-depedency) $ bundle exec shindont tests/models/compute/storage_account_tests.rb 
[fog][WARNING] Setting default fog timeout to 2000 seconds

  Fog::Compute[:azure] | storage account model (azure, compute) +++++++  
  7 succeeded in 0.173655 seconds

vishrut@visshamac fog-azure (update-azure-depedency) $ bundle exec shindont tests/requests/compute/images_tests.rb 
[fog][WARNING] Setting default fog timeout to 2000 seconds

  Fog::Compute[:azure] | images request (azure, compute) +++  
  3 succeeded in 0.175689 seconds

vishrut@visshamac fog-azure (update-azure-depedency) $ bundle exec shindont tests/requests/compute/servers_tests.rb 
[fog][WARNING] Setting default fog timeout to 2000 seconds

  Fog::Compute[:azure] | servers request (azure, compute) +++  
  3 succeeded in 0.175277 seconds

vishrut@visshamac fog-azure (update-azure-depedency) $ bundle exec shindont tests/requests/compute/storage_accounts_tests.rb 
[fog][WARNING] Setting default fog timeout to 2000 seconds

  Fog::Compute[:azure] | storage accounts request (azure, compute) +++  
  3 succeeded in 0.175401 seconds

Unfortunately, I couldn't validate database tests due to the following error but looks like it exists even without my changes. I haven't got a chance to dig deep into it but please verify whether that exists or not and then I can dig deep to resolve it :)

vishrut@visshamac fog-azure (master) $ bundle exec shindont tests/models/compute/database_tests.rb 
[fog][WARNING] Setting default fog timeout to 2000 seconds

  Fog::Compute[:azure] | database model (azure, compute)       
      /Users/vishrut/repos/fog-azure/tests/models/compute/database_tests.rb
        The database model should
        Fog::Compute[:azure] | database model (azure, compute)
      uninitialized constant Azure::SqlDatabaseManagement::SqlDatabase
Did you mean?  Azure::SqlDatabaseManagement (NameError)
        /Users/vishrut/repos/fog-azure/lib/fog/azure/requests/compute/list_databases.rb:33:in `list_databases'
        /Users/vishrut/repos/fog-azure/lib/fog/azure/models/compute/databases.rb:33:in `all'
        /Users/vishrut/repos/fog-azure/tests/models/compute/database_tests.rb:27:in `block (2 levels) in <top (required)>'
        /Users/vishrut/.rvm/gems/ruby-2.3.0/gems/shindo-0.3.8/lib/shindo.rb:79:in `instance_eval'
        /Users/vishrut/.rvm/gems/ruby-2.3.0/gems/shindo-0.3.8/lib/shindo.rb:79:in `tests'
        /Users/vishrut/repos/fog-azure/tests/models/compute/database_tests.rb:26:in `block in <top (required)>'
        /Users/vishrut/.rvm/gems/ruby-2.3.0/gems/shindo-0.3.8/lib/shindo.rb:79:in `instance_eval'
        /Users/vishrut/.rvm/gems/ruby-2.3.0/gems/shindo-0.3.8/lib/shindo.rb:79:in `tests'
        /Users/vishrut/.rvm/gems/ruby-2.3.0/gems/shindo-0.3.8/lib/shindo.rb:38:in `initialize'
        /Users/vishrut/.rvm/gems/ruby-2.3.0/gems/shindo-0.3.8/lib/shindo.rb:13:in `new'
        /Users/vishrut/.rvm/gems/ruby-2.3.0/gems/shindo-0.3.8/lib/shindo.rb:13:in `tests'
        /Users/vishrut/repos/fog-azure/tests/models/compute/database_tests.rb:22:in `<top (required)>'
        /Users/vishrut/.rvm/gems/ruby-2.3.0/gems/shindo-0.3.8/lib/shindo/bin.rb:61:in `load'
        /Users/vishrut/.rvm/gems/ruby-2.3.0/gems/shindo-0.3.8/lib/shindo/bin.rb:61:in `block (2 levels) in run_in_thread'
        /Users/vishrut/.rvm/gems/ruby-2.3.0/gems/shindo-0.3.8/lib/shindo/bin.rb:58:in `each'
        /Users/vishrut/.rvm/gems/ruby-2.3.0/gems/shindo-0.3.8/lib/shindo/bin.rb:58:in `block in run_in_thread'

Also, please let me know if there is an other way I should be testing. Thanks!

jeffmendoza commented 8 years ago

I'm not sure about the sqldatabase issues. I didn't work on those. This all looks good to me, so I'll merge.

jeffmendoza commented 8 years ago

@vishrutshah Are you interested in testing out any of the other PR's on this repo?

vishrutshah commented 8 years ago

@jeffmendoza Thanks for accepting PR & inviting me the PR party 👍 . I'll definitely look into other PRs, test them out & post my finding in the respective comments as I get chance.