search

fog / fog-backblaze

Integration library for gem fog and Backblaze B2 Cloud Storage
MIT License
19 stars 22 forks source link

6 private bucket #20

Open kevivmatrix opened 4 years ago

kevivmatrix commented 4 years ago

Fixes #6

philister commented 4 years ago

A useful PR! Thanks for that work!

Looks good for me and works with our carrierwave.

Things, I would implement once this PR is merged (I dont know how to create PR which is based on another PR):

Arguments expires and options for url() https://github.com/inkoop/fog-backblaze/blob/6-private-bucket/lib/fog/backblaze/storage/models/file.rb#L56 As in https://github.com/fog/fog-aws/blame/8185a56f25b12746669e869f72d8e9207a77aa08/lib/fog/aws/models/storage/file.rb#L240 I will implement expires and options[:b2ContentDisposition]

The "default" expiry is imo too long for a private bucket: https://github.com/fog/fog-backblaze/blob/c9b1e9dd52a91922620f7b01884f66124d8b3314/lib/fog/backblaze/storage/real.rb#L243 )

I also noticed, public_url should be nil, if bucket is private, as in fog-aws: https://github.com/fog/fog-aws/blame/8185a56f25b12746669e869f72d8e9207a77aa08/lib/fog/aws/models/storage/file.rb#L170

kevivmatrix commented 4 years ago

@philister Great! I hope it gets reviewed and merged soon.

Paxa commented 4 years ago

Thank you so much! I will need some time to review this