Reapply "Delegate methods that accept keywords from Fog::Collection t…

fog / fog-core

fog's core, shared behaviors without API and provider specifics

MIT License

45 stars 95 forks source link

Reapply "Delegate methods that accept keywords from Fog::Collection t… #296

Closed DimitriosLisenko closed 10 months ago

DimitriosLisenko commented 10 months ago

…o Array correctly for Ruby 2.x and Ruby 3.x (#292)" (#295)

This reverts commit 917bcb73f5a6c1c0f29fbf510345c5d8e4a1f490.

geemus commented 10 months ago

Thanks again. I imagine this deserves a release too?

DimitriosLisenko commented 10 months ago

Agree, though I don't think it's necessarily urgent to release because most Array methods actually don't accept keywords, I think the only ones ATM are Array#shuffle, Array#sample, and Array#pack (and maybe whatever else people have monkey patched Array with). Up to you, I imagine it can wait until after the holidays.

geemus commented 10 months ago

Ah yeah, good point. Yep, my inclination was definitely to wait until the new year as I'm going to be otherwise occupied and would hate to accidentally push a bad release and be unavailable to address it.

geemus commented 10 months ago

This should now be released in v2.4.0, thanks again!

DimitriosLisenko commented 10 months ago

Thank you!