search

fog / fog-google

Fog for Google Cloud Platform
MIT License
98 stars 146 forks source link

Fix GoogleXML::File#save incorrectly passing body to headers #508

Closed stanhu closed 3 years ago

stanhu commented 3 years ago

Previously if a file were created with NULL bytes, File#save would fail because the raw body was being set in the header. We now only allow metadata that starts with x-goog-meta- to be passed in as custom headers.

Closes #507

Temikus commented 3 years ago

@stanhu You're the best, thanks for the PR! Lemme quickly run our main CI and I'll merge if everything's green.

stanhu commented 3 years ago

@Temikus Thanks, would you mind releasing a new version?

Temikus commented 3 years ago

@stanhu Yeah, of course. I just wanted to bundle changes from https://github.com/fog/fog-google/pull/509 into it. I expect to roll out today.