search

fog / fog-google

Fog for Google Cloud Platform
MIT License
98 stars 146 forks source link

Stop using obsoleted URI.encode method #517

Closed stanhu closed 3 years ago

stanhu commented 3 years ago

URI.encode has been marked obsolete and has been removed from Ruby v3.0. We use the addressable gem to properly escape the path parameter.

codecov[bot] commented 3 years ago

Codecov Report

Merging #517 (2b23bc9) into master (fee365b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files         311      311           
  Lines        5217     5217           
=======================================
  Hits         4615     4615           
  Misses        602      602

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89acae9...0c646fd. Read the comment docs.

stanhu commented 3 years ago

@Temikus Could you take a look at this pull request?

github-actions[bot] commented 3 years ago

This pr has been marked inactive and will be closed if no further activity occurs.

Temikus commented 3 years ago

@stanhu I can merge if you can fixup conflicts. Sorry again for the delay.

stanhu commented 3 years ago

I think this was resolved in 67c34c3934a5cb0b8063d2bd9f0d496ab16d0e1a, so let's just go with that.