Closed sethboyles closed 2 years ago
@sethboyles Thanks, I've kicked off the ci for us. This seems fine to me, but I would like @Temikus to have a chance to speak up, in case I'm missing something.
@Temikus Thanks!
Released in v1.18.0.
thank you!
This is an alternative to https://github.com/fog/fog-google/pull/422, in order to get newer versions of fog-core to enable compatibility with other fog provider gems.
Looking into the history, it looks like a similar change was reverted: https://github.com/fog/fog-google/pull/419 https://github.com/fog/fog-google/pull/487
There is talk of a regression, but all unit tests pass and as far as I can tell the only issue is the deprecation warnings.
It's been years since talk doing the update 'properly' and https://github.com/fog/fog-google/pull/422 seems to be stuck in limbo. At this point this gem lagging behind fog-core and other provider gems is no longer a minor inconvenience--it is blocking us from getting new features in other provider gems and from upgrading to Ruby 3.
We would much rather allow the deprecation warnings than continue to be stuck on a very old version (1.7, per this comment). That version is blocking us on upgrading other gems because some of its dependencies are locked to old versions that are incompatible with other gems.
After this is merged, we can tackled the deprecation warnings piecemeal, or we those who are annoyed by them can silence them (or pin to fog-core 2.1).
cc @Temikus @geemus
Authored-by: Seth Boyles sboyles@pivotal.io