search

fog / fog-google

Fog for Google Cloud Platform
MIT License
99 stars 146 forks source link

Generate URIs using Addressable #596

Closed stanhu closed 1 year ago

stanhu commented 1 year ago

This fixes https://github.com/fog/fog-google/issues/590.

stanhu commented 1 year ago

@geemus @Temikus Could you review?

geemus commented 1 year ago

Released in v1.21.0

stanhu commented 1 year ago

@geemus Thanks for the quick turnaround!

I tried upgrading to v1.21.0, but got:

Because google-cloud-storage >= 1.43.0 depends on google-apis-storage_v1 ~> 0.19.0
  and fog-google >= 1.20.0 depends on google-apis-storage_v1 ~> 0.20,
  google-cloud-storage >= 1.43.0 is incompatible with fog-google >= 1.20.0.
So, because Gemfile depends on fog-google ~> 1.21
  and Gemfile depends on google-cloud-storage ~> 1.44.0,
  version solving has failed.

I think https://github.com/fog/fog-google/pull/597 would fix that.