Open mateomurphy opened 1 year ago
I'm running into an issue when trying to mock google storage:
storage = Fog::Storage::Google.new({ :google_storage_access_key_id => "id", :google_storage_secret_access_key => "key" }) bucket = storage.directories.create(key: "name") pp bucket.files.all # returns [] bucket = storage.directories.create(key: "name-with-dashes") pp bucket.files.all # raises Excon::Error::BadRequest
This happens because this line of code rejects names that have non word characters in them: https://github.com/fog/fog-google/blob/master/lib/fog/storage/google_xml/requests/get_bucket.rb#L52
However according to google's documentation, dashes, underscores and dots are legal: https://cloud.google.com/storage/docs/buckets#naming
BTW I forked and modified this, and can submit a PR if that would be helpful
@mateomurphy very! Please do 🙏
I'm running into an issue when trying to mock google storage:
This happens because this line of code rejects names that have non word characters in them: https://github.com/fog/fog-google/blob/master/lib/fog/storage/google_xml/requests/get_bucket.rb#L52
However according to google's documentation, dashes, underscores and dots are legal: https://cloud.google.com/storage/docs/buckets#naming