Spruce up attaching and detaching disks on running servers

fog / fog-google

Fog for Google Cloud Platform

MIT License

99 stars 146 forks source link

Spruce up attaching and detaching disks on running servers #613

Closed rchekaluk closed 7 months ago

rchekaluk commented 8 months ago

As a new fog-google user, I encountered various issues in dynamically attaching and detaching disks against a running server, namely:

https://github.com/fog/fog-google/issues/611
https://github.com/fog/fog-google/issues/612
Error when running under Ruby 3.x: ArgumentError: wrong number of arguments (given 2, expected 1)
No example that demonstrates usage how to attach and detach disks against a running server

Temikus commented 7 months ago

Thank you very much! Changes LGTM 👍

There's a cleanup routine needed to clean up the drives in integration tests but I'll add that myself. Not waiting for workflows to finish as we're having some issues with our GCP project at the moment and I don't want to block you.