search

fog / fog-libvirt

libvirt provider for fog
MIT License
16 stars 42 forks source link

Retrieve VM IP address using libvirt #11

Closed dcbw closed 8 years ago

dcbw commented 8 years ago

Requires ruby-libvirt 0.6.0 plus this patch:

https://www.redhat.com/archives/libvir-list/2016-January/msg00147.html

Closes #8

dcbw commented 8 years ago

I assume you want testcases too, but does this approach look OK? How would backwards compat for ruby-libvirt < 0.6.x work?

dcbw commented 8 years ago

ruby-libvirt patch has been committed: http://libvirt.org/git/?p=ruby-libvirt.git;a=commit;h=c2d4192ebf28b8030b753b715a72f0cdf725d313

dcbw commented 8 years ago

@strzibny any thoughts on this patch? The CI errors don't seem to be related to the patch as they happen for me without it too.

dcbw commented 8 years ago

Repush to see if tests work now... bundle install (which the test is doing) works for me locally on F23.

plribeiro3000 commented 8 years ago

Which ruby version are you using in your own machine?

dcbw commented 8 years ago

@plribeiro3000 ruby 2.2.4 (on Fedora 23)

plribeiro3000 commented 8 years ago

@dcbw Could you add some tests around this?

Thanks.

dcbw commented 8 years ago

@plribeiro3000 sure, will do.

plribeiro3000 commented 8 years ago

Awesome. Thanks!

dcbw commented 8 years ago

@plribeiro3000 PTAL, thanks!

plribeiro3000 commented 8 years ago

Thanks!

fduminy commented 8 years ago

Is that integrated in libvirt-java ? I can't find any update since almost one year on redhat/github repositories. Who is/are the maintainer(s) ?

plribeiro3000 commented 8 years ago

@fduminy Dunno about the libvirt-java project. Don't even know where is the repo. Maybe you should open a ticket there?