search

fog / fog-libvirt

libvirt provider for fog
MIT License
16 stars 42 forks source link

Add handling of block volumes with a dev source. #117

Closed rwf14f closed 1 year ago

rwf14f commented 2 years ago

This fixes issue #110.

rwf14f commented 2 years ago

According to the libvirt documentation, the source tag doesn't have a name attribute. Adding it to an domain xml file will cause schema validation to fail (libvirt 8.0.0, qemu 6.2.0). It might be worth removing the code that checks the name attribute.

lestercheung commented 1 year ago

Is there any plans to merge this? libvirtd in EL8 won't work if the configuration refers to a LVM block device using the "file" attribute so would love to see this merged.

This foreman forum post bought me here.