This removes the use of ERB to construct XML and instead always uses a builder.
The primary motivation was that the ERB invocation was raising an error and an XML builder guarantees valid XML. While doing this I figured out that at least Pool doesn't have a .to_xml and Network.to_xml was just broken. Pool.to_xml does work, but it is noted in the docs (https://libvirt.org/formatstorage.html) that some fileds (allocation, capacity & available) are not applicable when creating a pool so it's questionable if they should be included.
Given that, I question if anyone actually uses this in practice, so I'm not too worried about breaking things.
This removes the use of ERB to construct XML and instead always uses a builder.
The primary motivation was that the ERB invocation was raising an error and an XML builder guarantees valid XML. While doing this I figured out that at least Pool doesn't have a .to_xml and Network.to_xml was just broken. Pool.to_xml does work, but it is noted in the docs (https://libvirt.org/formatstorage.html) that some fileds (
allocation,capacity&available) are not applicable when creating a pool so it's questionable if they should be included.Given that, I question if anyone actually uses this in practice, so I'm not too worried about breaking things.