search

fog / fog-libvirt

libvirt provider for fog
MIT License
16 stars 42 forks source link

Catching exception when running stat on non-existent volume #14

Closed arielsalvo closed 8 years ago

arielsalvo commented 8 years ago

How about this new version? Or do you prefer I omit the "begin-end" block?

plribeiro3000 commented 8 years ago

Seems good to me. Can you confirm it is working with this change?

arielsalvo commented 8 years ago

I tested it by allowing jenkins to run multiple configurations and multiple projects in parallel. It seems to have done the trick regarding volumes. Basically, this change ignores volumes that are not ready yet, so it should be OK.

I got a similar error from the list_domains.rb file (I added the comment in the issue) but it was rare. I think vagrant/libvirt takes a lot more time time bringing up a volume than a domain, so it makes a lot of sense that list_volumes should fail a lot more often than list_domains.

plribeiro3000 commented 8 years ago

:+1:

plribeiro3000 commented 8 years ago

Thank you for your time working on this!

arielsalvo commented 8 years ago

Remember to bump the version.... I don't know how you handle that in this project

plribeiro3000 commented 8 years ago

@arielsalvo Yeah. I'm actually part of the fog core team and help review stuff but regarding fog-libvirt i don't have permission on rubygem so i can't do a release.

@strzibny is your man here. =)

strzibny commented 8 years ago

Yeah, I can do a release with this included. Edit: And we should inctroduce CHANGELOG.

plribeiro3000 commented 8 years ago

Awesome. Thx. Let US know when The realeas is out please. Thanks!

Em sex, 19 de fev de 2016 03:54, Josef Strzibny notifications@github.com escreveu:

Yeah, I can do a release with this included.

— Reply to this email directly or view it on GitHub https://github.com/fog/fog-libvirt/pull/14#issuecomment-186185394.