search

fog / fog-libvirt

libvirt provider for fog
MIT License
16 stars 42 forks source link

minitest-stub-const is not use anywhere #143

Open voxik opened 2 weeks ago

voxik commented 2 weeks ago

According to log, it wasn't ever used.

voxik commented 2 weeks ago

The test matrix would probably deserve some update 🤔

ekohl commented 2 weeks ago

Yes, and overall #140 is one we need to finish because currently all tests are failing. Though I've been thinking about pinning the dependency in the short term.

voxik commented 2 weeks ago

because currently all tests are failing. Though I've been thinking about pinning the dependency in the short term.

Yes, ruby-libvirt 0.8.2 should fix the test failures. I think this is the issue:

$ ruby -r libvirt -e '::Libvirt::Domain.new()'
-e:1:in `new': allocator undefined for Libvirt::Domain (TypeError)
        from -e:1:in `<main>'
voxik commented 2 weeks ago

Ah, see your discussion in https://gitlab.com/libvirt/libvirt-ruby/-/merge_requests/35 now