search

fog / fog-libvirt

libvirt provider for fog
MIT License
16 stars 42 forks source link

Set iso_dir from image path in user-data ISO upload #20

Closed domcleal closed 8 years ago

domcleal commented 8 years ago

When the default pool is configured to a location other than /var/lib/libvirt/images, the iso_dir is now set to the uploaded location of the user-data image rather than defaulting to default_iso_dir.

dLobatog commented 8 years ago

:+1: - it points to the right location with this fix

almereyda commented 8 years ago

This seems important for thin provisioning. Is there any apparent reason why the Travis build fails, but the branch stays mergeable?

The diff doesn't seem to be too excessive.

domcleal commented 8 years ago

The Travis CI build is failing due to a rubygems issue, which could probably be worked around by setting sudo: false or installing a newer version of rubygems in the script.

The merge check is just whether the patch merges cleanly.

plribeiro3000 commented 8 years ago

@domcleal Could you push that change into your PR so we can check if it fix the issue?

Thanks!

domcleal commented 8 years ago

Sure, updated to install a newer version of Bundler (not rubygems, I misremembered) in the Travis CI script. Tests now pass.

plribeiro3000 commented 8 years ago

Thanks!

dLobatog commented 8 years ago

How about a new patch release to include this? :smile:

plribeiro3000 commented 8 years ago

Just released as 0.2.0. Sorry for the delay.

dLobatog commented 8 years ago

Thanks!