Allow update_display on VMs with non-auto keymap

fog / fog-libvirt

libvirt provider for fog

MIT License

16 stars 42 forks source link

Allow update_display on VMs with non-auto keymap #30

Closed tbrisker closed 7 years ago

tbrisker commented 7 years ago

If the vnc keymap has been changed from auto to, for example, en-us, calling update_display will fail with a "Call to virDomainUpdateDeviceFlags failed: internal error cannot change keymap setting on vnc graphics" error. This commit changes it so that if no keymap has been passed explicitly in the options we will use the keymap that is currently used.

plribeiro3000 commented 7 years ago

@strzibny Could you please take a look at this PR? I'm afraid i can't just look at the code to merge this.

mmoll commented 7 years ago

What's the status here?

BTW, there are quite some people from @theforeman using fog-libvirt actively, if new maintainers need to be found...

strzibny commented 7 years ago

This looks good to me, I will merge. @mmoll it would be awesome if some folks from Foreman wants to co-maintain :) (anyone can shoot me an e-mail).

mmoll commented 7 years ago

☝️ @lzap @tbrisker ☝️