fog / fog-libvirt

libvirt provider for fog
MIT License
16 stars 42 forks source link

Port defaults to -1 #34

Closed td512 closed 7 years ago

td512 commented 7 years ago

Hey all,

In libvirt/models/compute/templates/server.xml.erb there is an error on line 49 that's causing the port to default to -1

Here's the fix:

<% if display[:port] and !(display[:port].empty?) %>port='<%= display[:port] %>' autoport='no' <% else %>port='-1' autoport='yes' <%end%> instead of port='<%= display[:port] %>' autoport='yes'

I've already tested it on my local cluster, and that stops the port defaulting to -1

plribeiro3000 commented 7 years ago

@td512 Could you open a PR with those changes?

Thanks!

td512 commented 7 years ago

All done @plribeiro3000

plribeiro3000 commented 7 years ago

Awesome. Thanks @td512 . =)