Skip over networks that no longer exist

fog / fog-libvirt

libvirt provider for fog

MIT License

16 stars 42 forks source link

Skip over networks that no longer exist #39

Closed omahn closed 3 years ago

omahn commented 7 years ago

If a user is running multiple libvirt clients concurrently it's possible to get into a situation where list_networks.rb will attempt to lookup a network that has been removed by another client. We hit this scenario ourselves today as we are rapidly creating and destroying both domains and virtual networks for testing purposes. This PR will simply skip over any networks that no longer exist but will still raise an exception for any other errors returned when attempting to lookup networks.

plribeiro3000 commented 7 years ago

Hey @omahn. sorry for the big delay here.

And again, i'm sorry for not being as helpul as i should but i'm not fully aware of this project's code so i need your help for some details (like the generic exception question).

strzibny commented 5 years ago

Shouldn't list_networks method just accept this as an option? (skip_missing_networks: for example)

github-actions[bot] commented 3 years ago

This pr has been marked inactive and will be closed if no further activity occurs.