search

fog / fog-libvirt

libvirt provider for fog
MIT License
16 stars 42 forks source link

Test the ip_command functions success path #51

Closed electrofelix closed 6 years ago

electrofelix commented 6 years ago

Add tests to call the ssh_ip_command and local_ip_command to ensure that variables are reference correctly and any required dependenencies are in place.

Include missing test dependency net::ssh, but leave it optional.

Fixes issue introduced in #29

electrofelix commented 6 years ago

@infernix this should solve the bug accidentally introduced, I'd added some more tests to ensure the test code actually exercises what is inside of ssh_ip_command and local_ip_command to a degree. This did result in me seeing an exception due to a missing dependency on net::ssh.

plribeiro3000 commented 6 years ago

Thanks @infernix And @electrofelix

infernix commented 6 years ago

Tested, working well. @plribeiro3000 any chance of a new minor version release? :+1:

plribeiro3000 commented 6 years ago

Doing now. =)

plribeiro3000 commented 6 years ago

Releases as 0.5.0. =)