fog-libvirt.gemspec: changed dependency for fog-core to ~>2.1

fog / fog-libvirt

libvirt provider for fog

MIT License

16 stars 44 forks source link

fog-libvirt.gemspec: changed dependency for fog-core to ~>2.1 #59

Closed johanneskastl closed 5 years ago

johanneskastl commented 5 years ago

Fixes issue #58.

Needs to be tested, if there are any regressions.

plribeiro3000 commented 5 years ago

Hello @johanneskastl .

thanks for the PR. Could you please remove the constraint at all?

We are trying to move to a state where the final user defines it.

johanneskastl commented 5 years ago

Hi,

sure, will do so this evening.

johanneskastl commented 5 years ago

Hi,

I reworked the PR to remove the version constraint for both fog-core and fog-xml. Not sure if you want to keep the other constraint for ruby-libvirt?

s.add_dependency('ruby-libvirt','>= 0.7.0')

johanneskastl commented 5 years ago

Has anyone had a chance to look at this yet?

strzibny commented 5 years ago

I relaxed the fox-core dependency in #64 (still keeping the lower requirement to be sure). Do you really need fox-xml to be relaxed as well? If so open a new PR please and we can discuss it. Since this is about fox-core I am closing it.

@johanneskastl thank you for the original patch.