Follow fog-core best practices.

fog / fog-libvirt

libvirt provider for fog

MIT License

16 stars 44 forks source link

Follow fog-core best practices. #61

Closed voxik closed 5 years ago

voxik commented 5 years ago

Following fog/fog-core#229, this gem needs to be namespaced.

Please note that this fixes the "libvirt has no compute service (Fog::Service::NotFound)" error as can be seen in the test result of PR #59. I have also tested this locally against fog-core 1.43 and this PR should be backward compatible.

strzibny commented 5 years ago

This patch looks good to me, I also tried with never versions of Ruby. Some people might still work with the old constants so this should be part of 0.6.0 release at the very least.

@voxik Thanks a lot for the patch!

Note: the Travis failures are troubles with Gemfile-edge which I will try to fix.