Handle blank text in allocation

fog / fog-libvirt

libvirt provider for fog

MIT License

16 stars 44 forks source link

Handle blank text in allocation #62

Closed apuntamb closed 4 years ago

apuntamb commented 5 years ago

This PR handles the failure caused when allocation is passed empty in foreman libvirt .

strzibny commented 5 years ago

Will this be always an empty string? Should we also guard against allocation being nil? Can you point me to the code in foreman where this happens and when?

apuntamb commented 5 years ago

@strzibny Hi. Sure the related foreman code where I'd made changes (in progress) is here: theforeman/foreman/#6300.

strzibny commented 4 years ago

Looks good to me, merging.

xprazak2 commented 4 years ago

thank you @strzibny! Could we get a new release with this fix please?

xprazak2 commented 4 years ago

@strzibny, any chance you will have time to cut a new release in a near future?

strzibny commented 4 years ago

Yes, I was waiting for https://github.com/fog/fog-libvirt/pull/66 and maybe even https://github.com/fog/fog-libvirt/pull/56