search

fog / fog-libvirt

libvirt provider for fog
MIT License
16 stars 44 forks source link

fog-libvirt.gemspec: remove version constraint on fog-xml #66

Closed johanneskastl closed 4 years ago

johanneskastl commented 4 years ago

Based on the discussion in #59, remove the version constraint on fog-xml.

Please ignore the branch name, this does not remove the dependency, only the version constraint.

strzibny commented 4 years ago

I would still keep the lowest requirement there since I do not believe it works well with all previous versions of fog-xml.

johanneskastl commented 4 years ago

Version 0.1.3 was released 2017, should we use that? Or allow all 0.1.x version by using ~> 0.1?

strzibny commented 4 years ago

I am for limiting it to higher than current ">= 0.1.1" and lower than "< 0.2". This way we avoid possible break for 0.2 but allow wide range of fog-xml versions (there might be people with various versions in the wild).

johanneskastl commented 4 years ago

I have now added a constraint that should be satisfied by all 0.1.x versions, but not by 0.2.x.