search

fog / fog-libvirt

libvirt provider for fog
MIT License
16 stars 42 forks source link

Update video card in server.xml.erb #71

Closed qpe-y9d37y closed 3 years ago

qpe-y9d37y commented 4 years ago

Changing video card from <model type='cirrus' vram='9216' heads='1'/> to <model type='qxl' ram='65536' vram='65536' vgamem='16384' heads='1'/> as 'cirrus-vga' is deprecated. This change removes the warning message "qemu-kvm: -device cirrus-vga,id=video0,bus=pci.0,addr=0x2: warning: 'cirrus-vga' is deprecated, please use a different VGA card instead" found in the libvirt logs when starting a VM.

plribeiro3000 commented 3 years ago

@qpe-y9d37y Wont this break old versions? Maybe we could keep it backwards compatible somehow?

lzap commented 3 years ago

I agree, this should be ideally a new flag with VGA being default it could be flipped when 1.0.0 is released (with other breaking changes).

lzap commented 3 years ago

We have another report that libvirt in CentOS 8.3 does not even work properly (VNC) with the old cirrus driver: https://community.theforeman.org/t/unable-to-open-the-vnc-console/23660

@plribeiro3000 what is your recommendation? I think something needs to be done here.

plribeiro3000 commented 3 years ago

Can we work towards making it backwards compatible?

I'm worried that it might be working for some and this change break it.

A simple conditional with a default for the actual value would be enough.

lzap commented 3 years ago

I agree, I can rewrite the patch and introduce a new argument for this, @qpe-y9d37y is from our (Foreman) community and I am not sure if there is still an interest in this. We have a bugreport from other our user so this is something we would like to fix.

But before that I must ask - what it takes in your community to get push permissions? I'd be interested, there seem to be a lot of work in here. Some PRs can be merged right away. Do you have some nomination process? I see 6 people from Foreman open source project in the list of contributors of this repo with two more having a PR opened. We are not newbies over here :)

Just in case: https://theforeman.org

lzap commented 3 years ago

@geemus I assume you guys are busy and I would like to help:

And this PR too is something I can work with the original author finding a backward compatible solution, but as you can see, I am not very motivated to start another work since all those PRs are just hanging. What can I do to get things moving again? :-)

geemus commented 3 years ago

@lzap thanks for the ping, this hadn't yet landed on my radar (I had largely delegated as I've never personally been a libvirt user). I'd be happy to add you to committers as a next step, sorry for the gap in service here. Just let me know if you need anything else to get this all moving again.

lzap commented 3 years ago

Thanks for the trust, I will go ahead and merge easy PRs and poke unfinished ones.

I'd also like to get a release out of doors too, who should I ping once the tag is ready? Is there some pre-release process like checking which version of fog-gore particular version of implementation is compatible with? I guess you guys do not do semantic versioning since the library is still at 0.y.z. Any documentation in that regard would be helpful.

Let's get things moving! 👍🏻

lzap commented 3 years ago

@qpe-y9d37y can you let me know if you are able to rewrite the patch in a way that new argument is added and by default the old video card configuration is kept but users can opt-in for the new one? We can deprecate the functionality, cut a new release and only after that we can talk about making a breaking change.

geemus commented 3 years ago

@lzap Of course, thanks for your offer to help us get this moving again.

I try my best to follow semantic (except the major, which honestly should probably just be 1 or higher now), so continuing that would be great.

I have release permissions, and given that the other folks have been inactive, pinging me is probably going to be best/smoothest. I don't think we have a clear pre-release process at present, it's been more ad-hoc, but maybe we should do more to make this explicit. I think for now we can just talk through any questions/concerns and proceed from there.

Similarly if you have questions or need support on particular issues, feel free to ping me and I'll do my best to answer questions and support.

github-actions[bot] commented 3 years ago

This pr has been marked inactive and will be closed if no further activity occurs.