Closed apatelKmd closed 4 years ago
@apatelKmd looks pretty good overall. Do you have any particular questions or things we can help with?
I have verified changes locally through using the bundle exec rake console
task and modifying existing vm autostart
attribute.
@geemus see the following:
I wanted to implement more natural setter method, def autostart = value
. Not knowing Ruby and the framework I settled with what I know def update_autostart
.
I am unable to fully test out request
test. I wanted to set/reset and test out the value of autostart
attribute but autostart?
always returns the default false
.
Other than the above mentioned two issues proposed changes are functional.
This is my first iteration to receive useful feedback. I wanted to test more thoroughly but saw the migration snippets from shindo to minitest.