search

fog / fog-libvirt

libvirt provider for fog
MIT License
16 stars 44 forks source link

Return empty collection if no matching volume found #75

Closed electrofelix closed 3 years ago

electrofelix commented 4 years ago

Change the saving of the return from get_volume to ensure the resulting list is empty if no volume was found based on the filter keys specified.

Update the mock to replicate similar behaviour that can be expected to be relied upon that highlights a small number of assumptions relying on existing mock behaviour that would not align with real world experiences.

electrofelix commented 4 years ago

@geemus wondering if you can help indicate how to correct the tests around the volume reload behaviour?

electrofelix commented 3 years ago

@geemus anything else needed for this to merge?