Allow the base namespace to be injected for use in extension layers

fog / fog-openstack-core

fog's core openstack behaviors without API and cloud provider specifics

Apache License 2.0

6 stars 8 forks source link

Allow the base namespace to be injected for use in extension layers #17

Closed mwhagedorn closed 10 years ago

mwhagedorn commented 10 years ago

Note that there is also a bug in there.. OSC isn't handling properly passing in connection options

mwhagedorn commented 10 years ago

This is the basis of secret sauce downstream of OSC, allows you to provide own service class implementatons to the base ServiceDiscovery class

mwhagedorn commented 10 years ago

@krames @elight @wchrisjohnson can you guys review and close this out? Its used in the extension layers.... it also addreses a bug where passed in connection_options are blown away

mwhagedorn commented 10 years ago

@wchrisjohnson the gemfile got put back..

mwhagedorn commented 10 years ago

@tokengeek @krames @geemus @wchrisjohnson anybody else? Can we get this thing merged?

tokengeek commented 10 years ago

Look's good to me.

But then it's Friday, almost quittin' time and sunny so everything looks good!

elight commented 10 years ago

LGTM

geemus commented 10 years ago

Seems good (I don't have permissions to merge though).