search

fog / fog-openstack-core

fog's core openstack behaviors without API and cloud provider specifics
Apache License 2.0
6 stars 8 forks source link

renamed gemspec,gem #28

Closed mwhagedorn closed 10 years ago

mwhagedorn commented 10 years ago

to be consistent with fog-core and extension for gem guidelines (and to allow bundler to load this...) changed the gemspec info

wchrisjohnson commented 10 years ago

This LGTM. I would suggest we all check our editors to ensure we aren't adding whitespace; there are several lines in this commit that simply eliminate whitespace.

wchrisjohnson commented 10 years ago

I would wait for a :thumbsup: or :thumbsdown: from @elight or @krames before merging this.

elight commented 10 years ago

Sorry. We were both at RC and off today. Will try to review tomorrow but traveling.

On Tue, Apr 22, 2014 at 11:14 AM, Chris Johnson notifications@github.com wrote:

I would wait for a :thumbsup: or :thumbsdown: from @elight or @krames before merging this.

Reply to this email directly or view it on GitHub: https://github.com/fog/fog-openstack-core/pull/28#issuecomment-41052084

mwhagedorn commented 10 years ago

interesting @wchrisjohnson .. so it turns out Rubymine is an aggressive whitespace assassinator :)

krames commented 10 years ago

@mwhagedorn LGTM :shipit: