Storage: Use @openstack_management_uri only

fog / fog-openstack

Fog for OpenStack Platform

MIT License

69 stars 130 forks source link

Storage: Use @openstack_management_uri only #424

Closed gildub closed 6 years ago

gildub commented 6 years ago

Uses @openstack_management_uri for scheme, host and port which allow to avoid dedicated instance variables. Adjusts Mock accordingly.

theopenlab-ci[bot] commented 6 years ago

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 13m 44s
fog-openstack-unittest-spec : SUCCESS in 14m 15s

theopenlab-ci[bot] commented 6 years ago

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 13m 57s
fog-openstack-unittest-spec : SUCCESS in 12m 50s

aufi commented 6 years ago

Look good to me, merging :+1:

chaadow commented 6 years ago

@gildub Hi, thank you for the fix. Can you please update the README to specify that openstack_auth_url now does not accept the version, and that you need to use openstack_identity_api_version: v3.0 instead. ( v2.0 is the default value if i'm not mistaken" thanks again. and if possible release on rubygems 👌

gildub commented 6 years ago

@chaadow, You're welcome.

I'll update the Readme (default is v3 not v2.0) and push a release soon after.

gildub commented 6 years ago

README file has been updated: https://github.com/fog/fog-openstack/pull/425

gildub commented 6 years ago

@chaadow, release 0.2.2 is now available.

chaadow commented 6 years ago

@gildub Thank you! I'll update my gem accordingly to support the latest version