fog / fog-openstack

Fog for OpenStack Platform
MIT License
69 stars 130 forks source link

Image::V1: Service type is now imagev1 #443

Closed gildub closed 6 years ago

gildub commented 6 years ago

Image service type v1 and v2 need to be differentiated. Since openstack service type [1] doesn't offer an alias to distinguish between image v1 and v2 and because v1 is depreciate, let's keep the "image" service type to v2 and assign "imagev1" to v1. While at it, let's also adds "imagev2" as a possible service type for v2.

https://github.com/fog/fog-openstack/issues/438

[1] https://git.openstack.org/cgit/openstack/service-types-authority/

theopenlab-ci[bot] commented 6 years ago

Build succeeded.

voelzmo commented 6 years ago

Is this about image or volume? The code and the commit message seem to be about different services, right?

voelzmo commented 6 years ago

@aufi I was talking about the PR description:

Since openstack service type [1] doesn't offer an alias to distinguish between volume v1 and v2 and because v1 is depreciate, let's keep the "image" service type to v2 and assign "volumev1" to v1. While at it, let's also adds "volumev2" as a possible service type for v2.

gildub commented 6 years ago

@voelzmo, @aufi, sorry I mixed up volume in the description. Fixed!