fog / fog-openstack

Fog for OpenStack Platform
MIT License
68 stars 130 forks source link

storage: add openstack_storage_url option #454

Open elthariel opened 5 years ago

elthariel commented 5 years ago

In order to support ACL management in my provider (OVH), I need to have users in a different tenant and I need to use another base URL for my storage calls. In the python client it is implemented using the OS_STORAGE_URL.

This is the equivalent option for fog.

I don't really know how to add tests to this, suggestions are highly welcomed

Signed-off-by: Julien 'Lta' BALLET contact@lta.io

theopenlab-ci[bot] commented 5 years ago

Build succeeded.

theopenlab-ci[bot] commented 5 years ago

Build succeeded.

theopenlab-ci[bot] commented 5 years ago

Build succeeded.

gildub commented 5 years ago

This looks good. Just a question, see above conversation. Regarding tests, since you have the module utils you should be able to easily unit test #management_url. For a good explanation and example check out https://chriskottom.com/blog/2015/03/testing-ruby-mixins-in-isolation/

theopenlab-ci[bot] commented 4 years ago

Build succeeded.

ares commented 2 years ago

@ShamoX seems reasonable to me and should be backwards compatible, thoughts?

ShamoX commented 2 years ago

Yes, seems good, but adding a test like @gildub proposed would improve confidence.

@elthariel still need help here to do it (even after @gildub proposition) ?