Ensure User's Password is always String

fog / fog-openstack

Fog for OpenStack Platform

MIT License

68 stars 130 forks source link

Ensure User's Password is always String #493

Closed aufi closed 5 years ago

aufi commented 5 years ago

When OpenStack User's password was a Number, fog-core coerced it to Numeric type, which caused HTTP 400 failure leading to print request malformed error message including the password.

Value's coercing function from fog-core is a feature and it should not be changed propably, so adding String cast directly to OpenStack provider.

theopenlab-ci[bot] commented 5 years ago

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 14m 41s
fog-openstack-unittest-spec : SUCCESS in 10m 30s

aufi commented 5 years ago

Travis fail for Ruby 2.5 seems not related to me (other versions pass).

djberg96 commented 5 years ago

:+1:

theopenlab-ci[bot] commented 5 years ago

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 15m 35s
fog-openstack-unittest-spec : SUCCESS in 13m 57s

aufi commented 5 years ago

Added Travis fix with bundler https://github.com/fog/fog-openstack/pull/498

theopenlab-ci[bot] commented 5 years ago

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 15m 00s
fog-openstack-unittest-spec : SUCCESS in 15m 58s

aufi commented 5 years ago

Travis is :green_apple:

aufi commented 5 years ago

Thanks for merge :+1:

Could we have a new release with this change? @Ladas @gildub @geemus

geemus commented 5 years ago

Looks like @ladas pushed a release.