search

fog / fog-openstack

Fog for OpenStack Platform
MIT License
68 stars 130 forks source link

Fix URLs to use v3 when only v2 endpoint is listed in the catalog #513

Open achevalet opened 4 years ago

achevalet commented 4 years ago

It covers the cases where we can authenticate with keystone v3 but the endpoint returned in the catalog is v2 see https://github.com/fog/fog-openstack/issues/492

You guys can probably do something much cleaner as I have poor ruby skills, but it fixes my issue and the tests passed so I'm proposing.. :-)

theopenlab-ci[bot] commented 4 years ago

Build succeeded.

theopenlab-ci[bot] commented 4 years ago

Build failed.

theopenlab-ci[bot] commented 4 years ago

Build succeeded.

theopenlab-ci[bot] commented 4 years ago

Build succeeded.

pdion891 commented 3 years ago

tested on an OpenStack not exposing a endpoint for v3 and this fix work fine.

ShamoX commented 2 years ago

Just have a little problem with that, it's missing tests implementation of the corrected bug.

I can believe @pdion891 on word but it seems a little risky for the others.

Implemented tests are passing anyway.

ares commented 2 years ago

A test would certainly be good, @achevalet please let us know if you plan to add one.

pdion891 commented 2 years ago

Just have a little problem with that, it's missing tests implementation of the corrected bug.

I can believe @pdion891 on word but it seems a little risky for the others.

Implemented tests are passing anyway.

For sure I've only validated the use case that was valid on my side where the /v3 is not exposed.

achevalet commented 2 years ago

Quite busy, I would be grateful if someone can contribute here