search

fog / fog-ovirt

MIT License
11 stars 21 forks source link

Fixes #26044 - Add VmType support for VM creation #76

Closed bagasse closed 5 years ago

bagasse commented 5 years ago

Also updated .rubocop_todo.yml because it is annoying to see tests fail for that but I can remove this commit if wanted.

UXabre commented 5 years ago

This looks okay to me :-) @shiramax, what do you think? :-)

bagasse commented 5 years ago

Tested on foreman 1.22.x and oVirt 4.3.x

shiramax commented 5 years ago

@bagasse thanks, I created a PR for the rubocop errors: https://github.com/fog/fog-ovirt/pull/78 so, please remove it from your PR. @bagasse , I know I permised to release a new fog-ovirt version today, but I think it's better to release a new version later, once all the open PRs will merge.

bagasse commented 5 years ago

@shiramax, I removed the rubocop part. No problem for the release, it will be nice to get all current PR merged.

shiramax commented 5 years ago

@bagasse please rebase

bagasse commented 5 years ago

@shiramax, done.