search

fog / fog-vsphere

Fog for vSphere
MIT License
36 stars 63 forks source link

Help prevent hard fail on nil undefined legacy networks. #157

Closed chris1984 closed 6 years ago

chris1984 commented 6 years ago

PR to work to prevent this with a hard fail:

https://bugzilla.redhat.com/show_bug.cgi?id=1612921

chris1984 commented 6 years ago

@timogoebel thanks for the review :) Do you want me to change it to make rubopcop happy or want me to add a line to disable the cop for this if block and renable it after? The latter would be easier

chris1984 commented 6 years ago

@timogoebel I went with the latter, updated if you want to merge.

timogoebel commented 6 years ago

Thanks, @chris1984.